[ https://issues.apache.org/jira/browse/IMPALA-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542596#comment-17542596 ]
Michael Smith edited comment on IMPALA-9221 at 5/26/22 5:25 PM: ---------------------------------------------------------------- Captured some perf numbers in [https://docs.google.com/spreadsheets/d/1rrgGjGvX9KkEfWDcZyTrowRKs6hZDXY60sRVrx0LWIU/edit?usp=sharing.] !image-2022-05-26-10-23-57-678.png|width=640,height=400! was (Author: JIRAUSER288956): Captured some perf numbers in [https://docs.google.com/spreadsheets/d/1rrgGjGvX9KkEfWDcZyTrowRKs6hZDXY60sRVrx0LWIU/edit?usp=sharing.] !image-2022-05-26-10-23-57-678.png|width=600,height=400! > Optimize HashRing's map implementation > -------------------------------------- > > Key: IMPALA-9221 > URL: https://issues.apache.org/jira/browse/IMPALA-9221 > Project: IMPALA > Issue Type: Improvement > Components: Backend > Affects Versions: Impala 3.4.0 > Reporter: Joe McDonnell > Assignee: Michael Smith > Priority: Major > Attachments: image-2022-05-26-10-23-57-678.png > > > The hash ring used for consistent scheduling currently uses a std::map for > the hash-to-IpAddr lookup. HashRing is heavy on reads, with writes only > happening when executors come and go. There are some cases where we copy the > HashRing. > The standard map uses a large number of small allocations. This hurts cache > performance, adds overhead, and also increases the cost of copying the > structure. Something like boost's flat_map or Abseil's btree_map is likely to > be more efficient. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org