[
https://issues.apache.org/jira/browse/IMPALA-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565996#comment-17565996
]
Joe McDonnell commented on IMPALA-11419:
----------------------------------------
[~boroknagyz] The fix covers all the important points, and there is nothing
urgent here. I will file a follow-up with a couple ideas for reorganizing some
of this.
> Incremental build is broken
> ---------------------------
>
> Key: IMPALA-11419
> URL: https://issues.apache.org/jira/browse/IMPALA-11419
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
>
> IMPALA-11384 broke incremental builds because:
> * added a custom target that always rewrites a few generated header files
> ** The files are getting included directly/indirectly in most files, so we
> always need to recompile a large part of the project
> * Didn't remove ${THRIFT_FILE_WE}_constants.cpp/h dependency from
> common/thrift/CMakeLists.txt
> ** These files are not generated anymore, so the build system always
> reconstruct all the generated files (because *_constant.cpp/h is always
> missing), and then builds every target that depend on them.
> IMPALA-11415 fixes a sporadic error during data loading, but it only covers
> the root cause, i.e. we unnecessarily regenerate thrift files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
