[ https://issues.apache.org/jira/browse/IMPALA-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on IMPALA-11645 started by Daniel Becker. ---------------------------------------------- > Remove PrintThriftEnum functions in debug-utils.cc > -------------------------------------------------- > > Key: IMPALA-11645 > URL: https://issues.apache.org/jira/browse/IMPALA-11645 > Project: IMPALA > Issue Type: Improvement > Reporter: Daniel Becker > Assignee: Daniel Becker > Priority: Major > > Before IMPALA-5690 we implemented operator<< for Thrift enums in Impala code. > These functions printed the names of the enums. > Then we upgraded to Thrift 0.9.3, but that release included THRIFT-2067, > which implemented operator<< for Thrift enums, but printed the number value > of enums instead of their names. To preserve the old behaviour in Impala, we > renamed our own implementations of operator<< to PrintThriftEnum, a function > that we defined for each Thrift enum we used, and which returned a string > with the names - not the numbers - of the enums. > After upgrading Thrift to a version that included THRIFT-3921 (any version > starting from 0.11.0), these PrintThriftEnum functions are no longer > necessary as the operator<< provided by Thrift now prints the names of enums, > which is the behaviour we want. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org