[ https://issues.apache.org/jira/browse/IMPALA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616066#comment-17616066 ]
ASF subversion and git services commented on IMPALA-8770: --------------------------------------------------------- Commit 3962ae1972e9e2d6592cdd5e305c021cf38c41bd in impala's branch refs/heads/master from Joe McDonnell [ https://gitbox.apache.org/repos/asf?p=impala.git;h=3962ae197 ] IMPALA-8770: Support building Docker images on Redhat-based distributions Currently, Impala supports building and testing Docker images on Ubuntu. This extends that same support to Redhat-based distributions: 1. This splits out the Docker build's OS package installation into a separate install_os_packages.sh script. This script detects the OS and calls apt or yum as appropriate. The script takes the argument --install-debug-tools, which installs extra tools like iproute2 and ping. This defaults to true for debug images and false for release images. 2. This modifies daemon_entrypoint.sh to detect the OS and set LD_LIBRARY_PATH appropriate to account for different locations of Java. 3. This modifies docker/setup_build_context.py to handle different locations of libkudu_client.so and add extra sanity checks on various libraries found via globs. 4. This modifies bin/jenkins/dockerized-*.sh test infrastructure to be able to install docker on either Ubuntu or Redhat. It also changes the exit logic to collect the container logs. Developers can override the base image for Redhat 7 and Redhat 8 builds via the IMPALA_REDHAT7_DOCKER_BASE and IMPALA_REDHAT8_DOCKER_BASE environment variables. These default to open source Redhat equivalents (Centos 7.9 and Rocky 8.5 respectively), but they are also known to work with Redhat UBI images. Testing: - Ran dockerised testing on Rocky 8.5 via the rocky-8.5-dockerised-tests job. - Ran GVO - Ran a Docker build on Centos7 with UBI7 as the base image Change-Id: Ibaff2560ef971ac2c2231a8e43921164ea1d2f4d Reviewed-on: http://gerrit.cloudera.org:8080/19006 Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> Tested-by: Joe McDonnell <joemcdonn...@cloudera.com> > Support alternative Docker base images > -------------------------------------- > > Key: IMPALA-8770 > URL: https://issues.apache.org/jira/browse/IMPALA-8770 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure > Reporter: Tim Armstrong > Assignee: Joe McDonnell > Priority: Critical > Labels: docker > > Currently we can only build against an Ubuntu16.04 base image. I have a use > case where I'd like to build against a custom CentOS 7 base image. > I think this has a few parts; > * Allow substituting a custom base image in Dockerfile > * Somehow generalise distro-specific steps like apt-get. > * Generalise scripts like daemon_entrypoint.sh to handle different distros, > e.g. CentOS > We should also consider dockerising the whole container build (at least > optionally) so that it's possible to build images for an OS different from > the host OS. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org