[ https://issues.apache.org/jira/browse/IMPALA-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627966#comment-17627966 ]
Joe McDonnell commented on IMPALA-11694: ---------------------------------------- Doing this fixes the spinlock issue seen on ARM. Before: {noformat} 20:59:27 Start 97: internal-queue-test 21:24:44 97/135 Test #97: internal-queue-test .............. Passed 1517.77 sec{noformat} After: {noformat} 12:59:09 Start 97: internal-queue-test 12:59:12 97/135 Test #97: internal-queue-test .............. Passed 2.81 sec{noformat} > Use C++ atomics for the implementation of gutil/atomicops.h > ----------------------------------------------------------- > > Key: IMPALA-11694 > URL: https://issues.apache.org/jira/browse/IMPALA-11694 > Project: IMPALA > Issue Type: Improvement > Components: Backend > Affects Versions: Impala 4.2.0 > Reporter: Joe McDonnell > Priority: Major > > Chromium switched the implementation of atomicops.h and family to use the > C++11 atomics library in this change: > [https://github.com/chromium/chromium/commit/57a4e4a50c673c25e9cdaab53e32f6e53aa0b574] > It allowed for a large simplification later on where most of the > platform-specific logic and assembly could be removed. This seems easier to > maintain than the current code. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org