[
https://issues.apache.org/jira/browse/IMPALA-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637722#comment-17637722
]
ASF subversion and git services commented on IMPALA-11734:
----------------------------------------------------------
Commit 08a04d2495c2fb0968917ff29c37b08b7bea0a1f in impala's branch
refs/heads/branch-4.2.0 from Daniel Becker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=08a04d249 ]
IMPALA-11734: TestIcebergTable.test_compute_stats fails in RELEASE builds
If the Impala version is set to a release build as described in point 8
in the "How to Release" document
(https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate),
TestIcebergTable.test_compute_stats fails:
Stacktrace
query_test/test_iceberg.py:852: in test_compute_stats
self.run_test_case('QueryTest/iceberg-compute-stats', vector,
unique_database) common/impala_test_suite.py:742: in run_test_case
self.__verify_results_and_errors(vector, test_section, result, use_db)
common/impala_test_suite.py:578: in __verify_results_and_errors
replace_filenames_with_placeholder) common/test_result_verifier.py:469:
in verify_raw_results VERIFIER_MAP[verifier](expected, actual)
common/test_result_verifier.py:278: in verify_query_result_is_equal
assert expected_results == actual_results E assert Comparing
QueryTestResults (expected vs actual): E 2,1,'2.33KB','NOT CACHED','NOT
CACHED','PARQUET','false','hdfs://localhost:20500/test-warehouse/test_compute_stats_74dbc105.db/ice_alltypes'
!= 2,1,'2.32KB','NOT CACHED','NOT
CACHED','PARQUET','false','hdfs://localhost:20500/test-warehouse/test_compute_stats_74dbc105.db/ice_alltypes'
The problem is the file size which is 2.32KB instead of 2.33KB. This is
because the version is written into the file, and "x.y.z-RELEASE" is one
byte shorter than "x.y.z-SNAPSHOT". The size of the file in this test is
on the boundary between 2.32KB and 2.33KB, so this one byte can change
the value.
This change fixes the problem by using a regex to accept both values so
it works for both snapshot and release versions.
Change-Id: Ia1fa12eebf936ec2f4cc1d5f68ece2c96d1256fb
Reviewed-on: http://gerrit.cloudera.org:8080/19260
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> TestIcebergTable.test_compute_stats fails in RELEASE builds
> -----------------------------------------------------------
>
> Key: IMPALA-11734
> URL: https://issues.apache.org/jira/browse/IMPALA-11734
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Daniel Becker
> Assignee: Daniel Becker
> Priority: Major
>
> If the Impala version is set to a release build as described in point 8 in
> the "How to Release" document
> ([https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate),]
> TestIcebergTable.test_compute_stats fails:
> h3. Stacktrace
> {code:java}
> query_test/test_iceberg.py:852: in test_compute_stats
> self.run_test_case('QueryTest/iceberg-compute-stats', vector,
> unique_database) common/impala_test_suite.py:742: in run_test_case
> self.__verify_results_and_errors(vector, test_section, result, use_db)
> common/impala_test_suite.py:578: in __verify_results_and_errors
> replace_filenames_with_placeholder) common/test_result_verifier.py:469: in
> verify_raw_results VERIFIER_MAP[verifier](expected, actual)
> common/test_result_verifier.py:278: in verify_query_result_is_equal assert
> expected_results == actual_results E assert Comparing QueryTestResults
> (expected vs actual): E 2,1,'2.33KB','NOT CACHED','NOT
> CACHED','PARQUET','false','hdfs://localhost:20500/test-warehouse/test_compute_stats_74dbc105.db/ice_alltypes'
> != 2,1,'2.32KB','NOT CACHED','NOT
> CACHED','PARQUET','false','hdfs://localhost:20500/test-warehouse/test_compute_stats_74dbc105.db/ice_alltypes'{code}
> The problem is the file size which is 2.32KB instead of 2.33KB. This is
> because the version is written into the file, and "x.y.z-RELEASE" is one byte
> shorter than "x.y.z-SNAPSHOT". The size of the file in this test is on the
> boundary between 2.32KB and 2.33KB, so this one byte can change the value.
> We could use a row_regex to accept both values so it works for both snapshot
> and release versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
