[ https://issues.apache.org/jira/browse/IMPALA-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786974#comment-17786974 ]
ASF subversion and git services commented on IMPALA-12333: ---------------------------------------------------------- Commit 10e816942ae240401ef2d55863a77181bc169eed in impala's branch refs/heads/master from Daniel Becker [ https://gitbox.apache.org/repos/asf?p=impala.git;h=10e816942 ] IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties SHOW CREATE TABLE outputs some unnecessary table properties, some of which are Iceberg-specific. This change removes the following table properties from SHOW CREATE TABLE statements: Iceberg-specific: - previous_metadata_location - current-schema - snapshot-count - current-snapshot-id - current-snapshot-summary - current-snapshot-timestamp-ms - default-partition-spec - uuid General: - numRows - numFiles - totalSize - numFilesErasureCoded - last_modified_by - last_modified_time - impala.events.catalogServiceId - impala.events.catalogVersion Testing: - Added a test class in test_show_create_table.py, TestShowCreateTableIcebergProperties, that tests that the above Iceberg-specific table properties (and some others that occur with Iceberg tables) are not included in SHOW CREATE TABLE statements. - Modified test_show_create_table.py::TestShowCreateTable - removed the above properties and some others that should not be included in SHOW CREATE TABLE statements from the ignore list that is used when comparing expected and actual SHOW CREATE TABLE statements - some of these previously ignored properties were listed among the expected table properties in 'show-create-table.test', this change removes them from there. Change-Id: Id6f2cb9194f685a583b0d550532eb2454f119666 Reviewed-on: http://gerrit.cloudera.org:8080/20676 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > SHOW CREATE TABLE outputs unnecessary table properties for Iceberg tables > ------------------------------------------------------------------------- > > Key: IMPALA-12333 > URL: https://issues.apache.org/jira/browse/IMPALA-12333 > Project: IMPALA > Issue Type: Bug > Components: Frontend > Reporter: Zoltán Borók-Nagy > Assignee: Daniel Becker > Priority: Major > Labels: impala-iceberg, ramp-up > > SHOW CREATE TABLE outputs unnecessary table properties for Iceberg tables, > e.g.: > * current-schema > * previous_metadata_location > * snapshot-count > * uuid > * impala.events.catalogVersion > We should not output these, as they are redundant and/or meaningless in new > table creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org