[ 
https://issues.apache.org/jira/browse/IMPALA-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792170#comment-17792170
 ] 

ASF subversion and git services commented on IMPALA-11542:
----------------------------------------------------------

Commit 67e4ff67cff6d6a77bfca43ef0c06b91f7a6661e in impala's branch 
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=67e4ff67c ]

IMPALA-11542: Implement pre-allocation in LLVM memory manager

Implements up-front allocation for the LLVM memory manager to avoid
disparate sections on ARM which can exceed the 4GB limit for ADRP
instructions and crash (or hit an assertion in debug mode).

This is an LLVM issue that we're fixing by providing a custom memory
manager. See the JIRA and
https://discourse.llvm.org/t/llvm-rtdyld-aarch64-abi-relocation-restrictions/74616
for further discussion.

Testing:
- passes debug test run on ARM
- pre-commit tests

Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675
Reviewed-on: http://gerrit.cloudera.org:8080/20692
Tested-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>


> TestFailpoints::test_failpoints crash in ARM build
> --------------------------------------------------
>
>                 Key: IMPALA-11542
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11542
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.1.0
>            Reporter: Quanlong Huang
>            Assignee: Michael Smith
>            Priority: Critical
>              Labels: arm
>             Fix For: Impala 4.4.0
>
>
> Saw the crash in 
> [https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-ARM/13]
> In the ERROR log:
> {noformat}
> Picked up JAVA_TOOL_OPTIONS: 
> -agentlib:jdwp=transport=dt_socket,address=30000,server=y,suspend=n  
> impalad: 
> /home/ubuntu/native-toolchain/source/llvm/llvm-5.0.1-asserts.src-p3/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:400:
>  void llvm::RuntimeDyldELF::resolveAArch64Relocation(const 
> llvm::SectionEntry&, uint64_t, uint64_t, uint32_t, int64_t): Assertion 
> `isInt<33>(Result) && "overflow check failed for relocation"' failed.
> Minidump in thread [20013]exec-finstance 
> (finst:1e4a0f56622f2a15:51c2970900000005) running query 
> 1e4a0f56622f2a15:51c2970900000000, fragment instance 
> 1e4a0f56622f2a15:51c2970900000005
> Wrote minidump to 
> /home/ubuntu/Impala/logs/ee_tests/minidumps/impalad/de4830d8-009d-47f4-f14bb68a-f0d8cd4c.dmp
>  {noformat}
> In the INFO log:
> {noformat}
> I0830 06:54:49.173234 11329 impala-beeswax-server.cc:516] query: Query {
>   01: query (string) = "SELECT STRAIGHT_JOIN *\n           FROM alltypes t1\n 
>                  JOIN /*+broadcast*/ alltypesagg t2 ON t1.id = t2.id\n        
>    WHERE t2.int_col < 1000",
>   03: configuration (list) = list<string>[10] {
>     [0] = "CLIENT_IDENTIFIE[...](273)",
>     [1] = "TEST_REPLAN=1",
>     [2] = "DISABLE_CODEGEN=False",
>     [3] = "BATCH_SIZE=0",
>     [4] = "NUM_NODES=0",
>     [5] = "DISABLE_CODEGEN_ROWS_THRESHOLD=0",
>     [6] = "MT_DOP=4",
>     [7] = "ABORT_ON_ERROR=1",
>     [8] = 
> "DEBUG_ACTION=4:GETNEXT:MEM_LIMIT_EXCEEDED|COORD_BEFORE_EXEC_RPC:JITTER@100@0.3",
>     [9] = "EXEC_SINGLE_NODE_ROWS_THRESHOLD=0",
>   },
>   04: hadoop_user (string) = "ubuntu",
> }
> ...
>   74: client_identifier (string) = 
> "failure/test_failpoints.py::TestFailpoints::()::test_failpoints[protocol:beeswax|table_format:seq/snap/block|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;'abort_on_error':1;'exec_sing",
> ...
> I0830 06:54:49.173739 11329 Frontend.java:1877] 
> 1e4a0f56622f2a15:51c2970900000000] Analyzing query: SELECT STRAIGHT_JOIN *
>            FROM alltypes t1
>                   JOIN /*+broadcast*/ alltypesagg t2 ON t1.id = t2.id
>            WHERE t2.int_col < 1000 db: functional_seq_snap {noformat}
> The client_identifier shows it's TestFailpoints::test_failpoints.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to