[
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799907#comment-17799907
]
Sean Yeh commented on IMPALA-5078:
----------------------------------
[~csringhofer] I got stuck when I originally picked up this ticket years back.
Current attack plan is:
# Set up the developer's environment with bootstrap script
# Build/compile project
# Break up the tests. I can follow yours and also break up the string and
decimal functions. My original idea was simply seperating out the string
functions.
# Update any unit tests/make sure project builds/compiles
# Send PR
When I ran the bootstrap script originally, I got past 100% but errored out on
some Hive connection issue. I'm considering creating a new VM and using ubuntu
18 instead of 16 (I use virtual box and ssh into the VM).
I haven't made as much progress since I'm running into issues with the
bootstrap script.
A question I have is:
Is this how to verify unit tests are passing after making the change?:
{code:java}
./buildall.sh -noclean -testdata
MAX_PYTEST_FAILURES=12345678 ./bin/run-all-tests.sh{code}
I'll make sure to reach out and message you if I end up returning the ticket.
> Break up expr-test.cc
> ---------------------
>
> Key: IMPALA-5078
> URL: https://issues.apache.org/jira/browse/IMPALA-5078
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Henry Robinson
> Assignee: Csaba Ringhofer
> Priority: Minor
> Labels: newbie, ramp-up
> Attachments: Screen Shot 2020-06-30 at 12.19.16 PM.png, Screen Shot
> 2020-07-10 at 1.01.43 PM.png, Screen Shot 2020-07-10 at 11.16.36 AM.png,
> Screen Shot 2020-07-10 at 11.27.57 AM.png, image-2020-07-10-13-22-48-230.png
>
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs
> to start slowing down a bit. Let's see if we can refactor it enough to have a
> couple of test files. Maybe moving all the string instructions into a
> separate {{expr-string-test.cc}}, and having a common header will be enough
> to make it a bit more manageable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
