[
https://issues.apache.org/jira/browse/IMPALA-12825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822602#comment-17822602
]
ASF subversion and git services commented on IMPALA-12825:
----------------------------------------------------------
Commit 5071f54a4ca9456efb302f737a13a9eb14710f5f in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5071f54a4 ]
IMPALA-12825: Install thrift into the impala-python virtualenv
impala-python currently gets its Thrift from the toolchain
by adding the appropriate Thrift toolchain directories to
the PYTHONPATH. This is a problem when switching to Python 3,
because the toolchain Thrift was built with Python 2 and
this can produce complicated bugs. In general, it is also
not a good idea to get Python dependencies from the toolchain.
This switches to installing Thrift into the impala-python
virtualenv, which lets the different Python versions have
their own copy of compiled files.
Testing:
- Ran a core job
Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5
Reviewed-on: http://gerrit.cloudera.org:8080/21046
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Install thrift into the impala-python virtualenv rather than using the
> toolchain
> --------------------------------------------------------------------------------
>
> Key: IMPALA-12825
> URL: https://issues.apache.org/jira/browse/IMPALA-12825
> Project: IMPALA
> Issue Type: Sub-task
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Priority: Major
>
> Right now, impala-python uses Thrift from the toolchain. This is a problem
> for supporting Python 3, because the toolchain builds Thrift with Python 2.
> This setup is hacky anyway. We should install thrift into the Python
> virtualenv and remove this reference.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
