[ 
https://issues.apache.org/jira/browse/IMPALA-12860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822657#comment-17822657
 ] 

Zoltán Borók-Nagy commented on IMPALA-12860:
--------------------------------------------

Let's have this comment here as well:

Invoking validateDeletedFiles() as well might also makes sense. 
[https://github.com/apache/iceberg/blob/08e31ce32d506e0dd95e4710ec9e9afba35efa7f/api/src/main/java/org/apache/iceberg/RowDelta.java#L95]

Though if we have validateNoConflictingDataFiles() then we are possibly good 
already (i.e. probably no need for validateDeletedFiles(), but we still need 
validateDataFilesExist()).

> Invoke validateDataFilesExist for RowDelta operations
> -----------------------------------------------------
>
>                 Key: IMPALA-12860
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12860
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>              Labels: impala-iceberg
>
> We must invoke validateDataFilesExist for RowDelta operations 
> (DELETE/UPDATE/MERGE).
> Without this a concurrent RewriteFiles (compaction) and RowDelta can corrupt 
> a table.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to