[
https://issues.apache.org/jira/browse/IMPALA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831972#comment-17831972
]
Joe McDonnell commented on IMPALA-12697:
----------------------------------------
Merged the fix:
{noformat}
commit 78a3723ad8251fbd786c276bd0f6b75a6b5bae74
Author: Laszlo Gaal <laszlo.g...@cloudera.com>
Date: Thu Mar 7 19:35:43 2024 +0100 IMPALA-12697: Set FAIL_ON_PUBLISH to
true by default
Ensure that a package upload failure fails the complete build process
instead of just producing an incomplete toolchain in silence.
This changes the default initialized value of the FAIL_ON_PUBLISH
environment variable to 1. This still allows Jenkins jobs to supply a
different value if it ever becomes necessary.
Change-Id: I156269e8b3b1fa5d743a8ab5a83810001f7dd648
Reviewed-on: http://gerrit.cloudera.org:8080/21134
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>
Tested-by: Joe McDonnell <joemcdonn...@cloudera.com>
{noformat}
> Native toolchain upload to S3 silently failed
> ---------------------------------------------
>
> Key: IMPALA-12697
> URL: https://issues.apache.org/jira/browse/IMPALA-12697
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Reporter: Michael Smith
> Assignee: Laszlo Gaal
> Priority: Major
>
> A native-toolchain build silently failed to upload to S3
> {code}
> 21:03:52 impala-toolchain-redhat8: Uploading
> /mnt/build/orc-1.7.9-p10-gcc-10.4.0.tar.gz to
> s3://native-toolchain/build/11-8dbe785e9e/orc/1.7.9-p10-gcc-10.4.0/orc-1.7.9-p10-gcc-10.4.0-ec2-package-centos-8-aarch64.tar.gz
> 21:03:52 impala-toolchain-redhat8: /mnt/functions.sh: line 383: 1119230
> Segmentation fault (core dumped) aws s3 cp --only-show-errors
> "${PACKAGE_FINAL_TGZ}" "${PACKAGE_S3_DESTINATION}"
> 21:03:52 impala-toolchain-redhat8: Uploading to mirror:
> 21:03:52 impala-toolchain-redhat8: Uploading
> /mnt/build/orc-1.7.9-p10-gcc-10.4.0.tar.gz to
> s3://native-toolchain-us-west-2/build/11-8dbe785e9e/orc/1.7.9-p10-gcc-10.4.0/orc-1.7.9-p10-gcc-10.4.0-ec2-package-centos-8-aarch64.tar.gz
> 21:03:52 impala-toolchain-redhat8: Cleaning /mnt/source/orc ...
> {code}
> It should have failed the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
