[
https://issues.apache.org/jira/browse/IMPALA-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836535#comment-17836535
]
ASF subversion and git services commented on IMPALA-12288:
----------------------------------------------------------
Commit 3fe856f8cdb344f47f9c1eaea1a48d86dbc0605c in impala's branch
refs/heads/branch-3.4.2 from zhangyifan27
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3fe856f8c ]
IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets
This patch adds a new option 'BUILD_WITH_NO_TESTS' to tell CMake not
to generate test targets. In order to be consistent with the previous
test workflow, this option is only set ON when building impala using
the 'buildall.sh' script with '-notest' and '-package' flags. This
is useful for a packaging build which do not need to build all test
binaries.
Testing:
- Ran 'buildall.sh -release -package' with and without '-notests'
flag and verified generated executables.
Backport notes: resolved conflicts in following files
- be/src/codegen/CMakeLists.txt
- be/src/exec/parquet/CMakeLists.txt
- be/src/testutil/CMakeLists.txt
- be/src/util/CMakeLists.txt
Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a
Reviewed-on: http://gerrit.cloudera.org:8080/20294
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Quanlong Huang <huangquanl...@gmail.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/21262
Reviewed-by: Yifan Zhang <chinazhangyi...@163.com>
Tested-by: Quanlong Huang <huangquanl...@gmail.com>
> Avoiding building all the backend tests when running a packaging build
> ----------------------------------------------------------------------
>
> Key: IMPALA-12288
> URL: https://issues.apache.org/jira/browse/IMPALA-12288
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: YifanZhang
> Priority: Major
> Fix For: Impala 4.3.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using the new packaging functionality in IMPALA-10262, the command
> "buildall.sh -package -release -notests" still builds all of the backend
> tests.
> Currently, the "-notests" flag doesn't change the list of targets generated
> by CMake. Instead, "-notests" changes the make target that is built by
> buildall.sh. So, the test targets still exist, but they aren't built.
> cpack seems to invoke a plain "make" with no target, and this builds
> everything including the tests.
> To avoid this, we would need a mode that tells CMake to avoid generating the
> test targets altogether. This could be very useful for a packaging build,
> because the backend tests take up significant time and disk space to build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
