[
https://issues.apache.org/jira/browse/IMPALA-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838396#comment-17838396
]
Joe McDonnell commented on IMPALA-12900:
----------------------------------------
Fixed by
{noformat}
commit ce8bc71ff7e0cfc0c39511308df8841f39fb03d2
Author: Joe McDonnell <joemcdonn...@cloudera.com>
Date: Tue Mar 12 21:47:12 2024 -0700 IMPALA-12900: Build binutils with -O3
The binutils build happens before we have switched over to
using the toolchain compiler. This means that it also does
not set CFLAGS/CXXFLAGS. The default optimization level
for binutils is -O2. It is possible that we could get a bit
extra speed by using -O3, so this sets CFLAGS/CXXFLAGS to use
-O3 for binutils.
Testing:
- Toolchain builds on x86_64 and ARM
Change-Id: I2e75db0759b4d3d4e6cc2ce929b1741808f1b771
Reviewed-on: http://gerrit.cloudera.org:8080/21145
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Laszlo Gaal <laszlo.g...@cloudera.com>
Tested-by: Joe McDonnell <joemcdonn...@cloudera.com>{noformat}
> Compile binutils with -O3 in the toolchain
> ------------------------------------------
>
> Key: IMPALA-12900
> URL: https://issues.apache.org/jira/browse/IMPALA-12900
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> Since the toolchain builds binutils with the native compiler (as the
> toolchain compiler hasn't been built yet), we haven't set CFLAGS yet. The
> default CFLAGS for binutils use -O2. It's possible that we could get a bit
> more speed by building with -O3. We should set CFLAGS/CXXFLAGS to use -O3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
