[
https://issues.apache.org/jira/browse/IMPALA-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842753#comment-17842753
]
ASF subversion and git services commented on IMPALA-13049:
----------------------------------------------------------
Commit d09c5024907aaf387aaa584dc86cb2b4d641a582 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d09c50249 ]
IMPALA-13049: Add dependency management for log4j2 to use 2.18.0
Currently, there is no dependency management for the log4j2
version. Impala itself doesn't use log4j2. However, recently
we encountered a case where one dependency brought in
log4-core 2.18.0 and another brought in log4j-api 2.17.1.
log4j-core 2.18.0 relies on the existence of the ServiceLoaderUtil
class from log4j-api 2.18.0. log4j-api 2.17.1 doesn't have this
class, which causes class not found exceptions.
This uses dependency management to set the log4j2 version to 2.18.0
for log4j-core and log4j-api to avoid any mismatch.
Testing:
- Ran a local build and verified that both log4j-core and log4j-api
are using 2.18.0.
Change-Id: Ib4f8485adadb90f66f354a5dedca29992c6d4e6f
Reviewed-on: http://gerrit.cloudera.org:8080/21379
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Abhishek Rawat <ara...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Add dependency management for the log4j2 version
> ------------------------------------------------
>
> Key: IMPALA-13049
> URL: https://issues.apache.org/jira/browse/IMPALA-13049
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend, Infrastructure
> Affects Versions: Impala 4.4.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Critical
>
> In some internal builds, we see cases where one dependency brings in one
> version of log4j2 and another brings in a different version on a different
> artifact. In particular, we have seen cases where Hive brings in log4j-api
> 2.17.1 while something else brings in log4j-core 2.18.0. This is a bad
> combination, because log4j-core 2.18.0 relies on the ServiceLoaderUtil class
> existing in log4j-api, but log4j-api 2.17.1 doesn't have it. This can result
> in class not found exceptions.
> Impala itself uses reload4j rather than log4j2, so this is purely about
> coordinating dependencies rather than Impala code.
> We should add dependency management for log4j-api and log4j-core. It makes
> sense to standardize on 2.18.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
