[ 
https://issues.apache.org/jira/browse/IMPALA-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846267#comment-17846267
 ] 

ASF subversion and git services commented on IMPALA-13051:
----------------------------------------------------------

Commit 3b35ddc8ca7b0e540fc16c413a170a25e164462b in impala's branch 
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3b35ddc8c ]

IMPALA-13051: Speed up, refactor query log tests

Sets faster default shutdown_grace_period_s and shutdown_deadline_s when
impalad_graceful_shutdown=True in tests. Impala waits until grace period
has passed and all queries are stopped (or deadline is exceeded) before
flushing the query log, so grace period of 0 is sufficient. Adds them in
setup_method to reduce duplication in test declarations.

Re-uses TQueryTableColumn Thrift definitions for testing.

Moves waiting for query log table to exist to setup_method rather than
as a side-effect of get_client.

Refactors workload management code to reduce if-clause nesting.

Adds functional query workload tests for both the sys.impala_query_log
and the sys.impala_query_live tables to assert the names and order of
the individual columns within each table.

Renames the python tests for the sys.impala_query_log table removing the
unnecessary "_query_log_table_" string from the name of each test.

Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855
Reviewed-on: http://gerrit.cloudera.org:8080/21358
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Riza Suminto <riza.sumi...@cloudera.com>


> Speed up test_query_log test runs
> ---------------------------------
>
>                 Key: IMPALA-13051
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13051
>             Project: IMPALA
>          Issue Type: Task
>    Affects Versions: Impala 4.4.0
>            Reporter: Michael Smith
>            Assignee: Jason Fehr
>            Priority: Minor
>
> test_query_log.py takes 11 minutes to run. Most of them use graceful 
> shutdown, and provide an unnecessary grace period. Optimize test_query_log 
> test runs, and do some other code cleanup around workload management.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to