[
https://issues.apache.org/jira/browse/IMPALA-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986416#comment-17986416
]
ASF subversion and git services commented on IMPALA-13389:
----------------------------------------------------------
Commit 1144d728d770ee45ee171f8898d15da7ac8774be in impala's branch
refs/heads/master from Surya Hebbar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1144d728d ]
IMPALA-14180: Fix imported query profiles navbar and datetime
This change corrects the improper rendering of nanosecond walltime
event timestamps in the text profile section of imported query profiles.
The timestamps are now displayed in minutes and seconds, instead of
being displayed in date format. (i.e. 2s120ms, 2ms498us)
The navbar rendering from incorrect declaration in webUI ES6 refactor
IMPALA-13389 has also been corrected.
Incorrectly added columns "Coordinator Slots" and "Executor Slots" in
IMPALA-13726: Add admission control slots to /queries page in webui
have been removed from the imported query profile section.
Change-Id: Id1ad10f469aec085e5b485b4c20d6ab89fe58034
Reviewed-on: http://gerrit.cloudera.org:8080/23067
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Refactor all webUI variable and function declarations to use ES6 syntax
> -----------------------------------------------------------------------
>
> Key: IMPALA-13389
> URL: https://issues.apache.org/jira/browse/IMPALA-13389
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Surya Hebbar
> Assignee: Surya Hebbar
> Priority: Major
>
> Using ES6 syntax with 'let' and 'const' greatly improves scoping,
> immutability, readability and helps in easier maintenance.
> In addition, it also improves the memory usage by reducing the scope.
> Also using ES6's arrow functions instead of traditional unnamed function
> declarations would be more cleaner and concise, where 'this' object within
> the function definition is bound to the surrounding context.
> It would be helpful if the variable and function names are revised to follow
> a single naming scheme, because in many instances across the scripts, no
> particular naming scheme has been followed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
