Sai Hemanth Gantasala created IMPALA-14208:
----------------------------------------------

             Summary: Improve the logic to detect writeId in catalogD
                 Key: IMPALA-14208
                 URL: https://issues.apache.org/jira/browse/IMPALA-14208
             Project: IMPALA
          Issue Type: Improvement
            Reporter: Sai Hemanth Gantasala
            Assignee: Sai Hemanth Gantasala


Comparing two ValidWriteIds logic in catalogD is currently little complicated. 
It would be nice to simply this logic. This came out of review comment: 
[https://gerrit.cloudera.org/c/21175/23/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java#2988]
{code:java}
if (MetastoreShim.getMajorVersion() > 2 &&
        AcidUtils.isTransactionalTable(msTable_.getParameters())) {
      ValidWriteIdList writeIdList = fetchValidWriteIds(client);
      prevWriteIdChanged = writeIdList.toString().equals(validWriteIds_);
      validWriteIds_ = new MutableValidReaderWriteIdList(writeIdList);
    } {code}
Typecasting writeIds to strings might be buggy. It would be nice to simplify 
this logic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to