[
https://issues.apache.org/jira/browse/IMPALA-14311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014920#comment-18014920
]
ASF subversion and git services commented on IMPALA-14311:
----------------------------------------------------------
Commit c23d3cb58adc558fe5e5064f9db6f6471c18d4ea in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c23d3cb58 ]
IMPALA-14311: Fix ASAN issue in test_query_cancel_load_tables
verifiers.test_verify_metrics.TestValidateMetrics.test_metrics_are_zero
fails in ASAN tests. This is because a client session opened by
test_query_cancel_load_tables is not cleanly closed.
This patch fix the issue by creating the Impala client within the run
method of web_pages_util.py using with-as statement.
This patch also attempt to fix flakiness in test_query_expiration by
validating that time_limit_expire_handle is actually closed in
Coordinator log (IMPALA-13444).
Testing:
- Pass test_web_pages.py test in ASAN build.
- Loop and pass test_query_expiration 50x in ASAN build.
Change-Id: I6fcf13902478535f6fa15f267edc83891057993c
Reviewed-on: http://gerrit.cloudera.org:8080/23302
Reviewed-by: Daniel Becker <daniel.bec...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Metric 'impala-server.num-open-hiveserver2-sessions' does not reach 0 in
> verifiers.test_verify_metrics.TestValidateMetrics.test_metrics_are_zero
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-14311
> URL: https://issues.apache.org/jira/browse/IMPALA-14311
> Project: IMPALA
> Issue Type: Bug
> Reporter: Daniel Becker
> Assignee: Riza Suminto
> Priority: Blocker
> Labels: broken-build
>
> verifiers.test_verify_metrics.TestValidateMetrics.test_metrics_are_zero fails
> in ASAN tests:
> h3. Error Message
> {code:java}
> AssertionError: Metric impala-server.num-open-hiveserver2-sessions did not
> reach value 0 in 60s. Actual value was '1'. Dumping debug webpages in JSON
> format... Dumped memz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/memz.json
> Dumped metrics JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/metrics.json
> Dumped queries JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/queries.json
> Dumped sessions JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/sessions.json
> Dumped threadz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/threadz.json
> Dumped rpcz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/rpcz.json
> Dumping minidumps for impalads/catalogds... Dumped minidump for Impalad PID
> 2993098 Dumped minidump for Impalad PID 2993100 Dumped minidump for Impalad
> PID 2993105 Dumped minidump for Catalogd PID 2993064{code}
> h3. Stacktrace
>
> {code:java}
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/tests/verifiers/test_verify_metrics.py:42:
> in test_metrics_are_zero
> verifier.verify_metrics_are_zero()
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/tests/verifiers/metric_verifier.py:52:
> in verify_metrics_are_zero
> self.wait_for_metric(metric, 0, timeout)
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/tests/verifiers/metric_verifier.py:67:
> in wait_for_metric
> self.impalad_service.wait_for_metric_value(metric_name, expected_value,
> timeout)
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/tests/common/impala_service.py:164:
> in wait_for_metric_value
> self.__metric_timeout_assert(metric_name, expected_value, timeout, value)
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/tests/common/impala_service.py:251:
> in __metric_timeout_assert
> assert 0, assert_string
> E AssertionError: Metric impala-server.num-open-hiveserver2-sessions did
> not reach value 0 in 60s. Actual value was '1'.
> E Dumping debug webpages in JSON format...
> E Dumped memz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/memz.json
> E Dumped metrics JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/metrics.json
> E Dumped queries JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/queries.json
> E Dumped sessions JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/sessions.json
> E Dumped threadz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/threadz.json
> E Dumped rpcz JSON to
> $IMPALA_HOME/logs/metric_timeout_diags_20250812_22:51:34/json/rpcz.json
> E Dumping minidumps for impalads/catalogds...
> E Dumped minidump for Impalad PID 2993098
> E Dumped minidump for Impalad PID 2993100
> E Dumped minidump for Impalad PID 2993105
> E Dumped minidump for Catalogd PID 2993064{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
