[
https://issues.apache.org/jira/browse/IMPALA-13237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014924#comment-18014924
]
ASF subversion and git services commented on IMPALA-13237:
----------------------------------------------------------
Commit 75ca356ed0451e1a98f70433a4d2729018b68d32 in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=75ca356ed ]
IMPALA-13237: [Patch 6] - Match Behavior of Older Impala Versions
Older versions of Impala set exec_state_ in ClientRequestState to
the error state earlier in the query processing than later versions.
This difference translates to when OpenTelemetry trace child spans
report an error status.
For example, in older Impala versions, if a query specifies a column
that does not exist, then the Planning child span has a status of
ERROR. However, in the latest version, the Planning span has a status of
OK, and only the Close span has a status of ERROR.
This difference caused the custom cluster test
test_otel_trace.py::TestOtelTrace::test_invalid_sql to fail in the
older Impala versions but pass in the latest version.
Additionally, older versions of Impala report a different default db.
The latest version reports whatever the client set. This difference
caused test_otel_trace.py::TestOtelTrace::test_retry_select_success
and test_otel_trace.py::TestOtelTrace::test_retry_select_failed to
fail in the older Impala versions because Impala used "tpch" as the
default db while the latest version used "default".
This change causes the OpenTelemetry trace child span where an error
actually occurs to report an error status, matching the behavior
of older Impala versions.
It also modifies test_otel_trace.py to expect the default db in the
OpenTelemetry trace "DefaultDb" attribute to match the query profile.
Testing accomplished by running the test_otel_trace.py custom cluster
tests.
Change-Id: If57aaef2da6d6904c66d0150f50ea9ac1c3ebc8c
Reviewed-on: http://gerrit.cloudera.org:8080/23293
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Send Query Lifecycle Traces to OTel
> -----------------------------------
>
> Key: IMPALA-13237
> URL: https://issues.apache.org/jira/browse/IMPALA-13237
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend, Frontend
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Critical
> Labels: observability
>
> Throughout the lifecycle of a query, several events happen. Implement OTel
> traces where each span is one step in the query lifecycle.
> These traces will be send to OTel systems using the OTel SDK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
