[ 
https://issues.apache.org/jira/browse/IMPALA-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021912#comment-18021912
 ] 

ASF subversion and git services commented on IMPALA-14451:
----------------------------------------------------------

Commit 9abbcf82ca2576c4523ff6a3a8c9fcd48fd889fe in impala's branch 
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9abbcf82c ]

IMPALA-14451: Log if memory-based admission is skipped

When admission control is enabled, but max memory for pool is not
configured, Impala skips memory-based admission completely, i.e. it
doesn't even take available host memory into account.

This behavior can lead to admitting many queries with large memory
consumption, potentially causing query failures due to memory
exhaustion.

Fixing the above behavior might cause regressions in some workloads,
so this patch just adds a new log message which makes it clear why
a query gets admitted, and also mentions possible failures.

Change-Id: Ib98482abc0fbcb53552adfd89cf6d157b17527fd
Reviewed-on: http://gerrit.cloudera.org:8080/23438
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Log if memory-based admission is skipped
> ----------------------------------------
>
>                 Key: IMPALA-14451
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14451
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>
> When admission control is enabled, but max memory for pool is not configured, 
> Impala skips memory-based admission completely, i.e. it doesn't even take 
> available host memory into account.
> This behavior can lead to admitting many queries with large memory 
> consumption, in which case the queries will fail with memory limit exceeded 
> errors.
> From the current logs it is not clear what happens, I think we should add at 
> least a LOG(INFO) message when memory-based admission is skipped.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to