[
https://issues.apache.org/jira/browse/IMPALA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18054782#comment-18054782
]
Dániel Gábor Vankó edited comment on IMPALA-14680 at 1/28/26 8:57 AM:
----------------------------------------------------------------------
Hi [~surya-hebbar]
Have you thought about enhancing the result verifiers similarly as well?
Currently 'row_regex:' works differently in the RUNTIME_PROFILE and in the
RESULTS section. (The latter still uses regex.match through the [ResultRow's
{{_{_}eq{_}_}}|https://github.com/apache/impala/blob/3dac0135fba0717dd977043e7ecc6b52bf55189f/tests/common/test_result_verifier.py#L165]
function.) Or that would not be that much performance gain?
was (Author: JIRAUSER308518):
Hi [~surya-hebbar]
Have you thought about enhancing the result verifiers similarly as well?
Currently 'row_regex:' works differently in the RUNTIME_PROFILE and in the
RESULTS section. (The latter still uses regex.match through the [ResultRow's
__eq__|https://github.com/apache/impala/blob/3dac0135fba0717dd977043e7ecc6b52bf55189f/tests/common/test_result_verifier.py#L165]
function.) Or that would not be that much performance gain?
> Improve row regex search syntax of runtime profile tests
> --------------------------------------------------------
>
> Key: IMPALA-14680
> URL: https://issues.apache.org/jira/browse/IMPALA-14680
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Surya Hebbar
> Assignee: Surya Hebbar
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> While enabling the aggregated profile IMPALA-9846, we improve the regex
> search implementation for the runtime profile tests.
> To improve this, we also need to improve the current `row_regex` search
> syntax used for search.
> This has greedy search syntax like ".*" at the beginning and end of
> row_regex, this is unnecessary and needs to be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
