[
https://issues.apache.org/jira/browse/IMPALA-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056241#comment-18056241
]
ASF subversion and git services commented on IMPALA-10706:
----------------------------------------------------------
Commit de853576d160281c5add82dec9a4299d4f226563 in impala's branch
refs/heads/master from Kunal Siyag
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=de853576d ]
IMPALA-10706: Remove unnecessary metastoreAccessLock_ from TableLoader
The metastoreAccessLock_ was added as a workaround for HIVE-5457, a
DataNucleus concurrency bug from 2013 that occurred when directly
connecting to the Hive Metastore backend database.
This lock is no longer necessary because:
- Impala uses RetryingMetaStoreClient (thrift client) to connect to HMS
over the network, not directly to the database
- The HIVE-5457 bug only affected direct DB connections via DataNucleus
- HMS handles concurrency internally via its own connection pooling
Removing this lock allows concurrent getTable() calls, improving
metadata loading performance.
Testing: Verified no remaining references to metastoreAccessLock_ exist.
Full testing will be done via gerrit-verify-dryrun.
Written with assistance from Antigravity (Claude Opus 4.5 model).
Change-Id: Id480c474c6a095e95a6f412e835a23dd7880f3f1
Reviewed-on: http://gerrit.cloudera.org:8080/23894
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Get rid of metastoreAccessLock_ in TableLoader
> ----------------------------------------------
>
> Key: IMPALA-10706
> URL: https://issues.apache.org/jira/browse/IMPALA-10706
> Project: IMPALA
> Issue Type: Improvement
> Components: Catalog
> Reporter: Vihang Karajgaonkar
> Assignee: Kunal Siyag
> Priority: Minor
> Labels: newbie
>
> https://github.com/apache/impala/blob/9c38568657d62b6f6d7b10aa1c721ba843374dd8/fe/src/main/java/org/apache/impala/catalog/TableLoader.java#L68
> has a synchronized block for metastore access which seems unnecessary
> anymore and should be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
