[
https://issues.apache.org/jira/browse/IMPALA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057892#comment-18057892
]
ASF subversion and git services commented on IMPALA-13419:
----------------------------------------------------------
Commit 720b94ad992d6bbde0d3c3ec69bd52e6b2d0e63c in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=720b94ad9 ]
IMPALA-13419: Improve test_http_socket_timeout
Uses a debug action in ExecuteStatement to add a sleep so we can test a
longer http_socket_timeout_s setting, which makes the test more
consistent. Fixes test failures with ASAN builds.
The change in testing means the failure no longer happens during 'SET
ALL' - which was too quick to be reliable - where impala-shell would
then CloseSession after failure. It now happens during executing the
query, which can result in leaving a query behind after the connection
is closed. Moves the test to custom cluster testing because there's no
way to reliably ensure the session is closed after disconnect;
idle_session_timeout should in theory work, but impala-shell has no way
to set it and detecting closed connections takes too long.
Fixes a DCHECK failure exposed by this test where registration fails
because the session has been closed and therefore the query driver was
not finalized:
760958 impala-server.cc:1522] ...] RegisterQuery(): session has been closed,
ignoring query.
760958 query-driver.cc:46] Check failed: finalized_.Load() Finalize() must
have been called
Testing: ran test_http_socket_timeout a bunch of times with ASAN.
Change-Id: Idf31bb1752586ebc296e5e8d62c035bac7371dfb
Reviewed-on: http://gerrit.cloudera.org:8080/23955
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_http_socket_timeout failed by timed out
> --------------------------------------------
>
> Key: IMPALA-13419
> URL: https://issues.apache.org/jira/browse/IMPALA-13419
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Michael Smith
> Priority: Critical
> Labels: broken-build
>
> Stacktrace
> {noformat}
> /data/jenkins/workspace/impala-cdw-master-staging-core-asan/repos/Impala/tests/shell/test_shell_commandline.py:1429:
> in test_http_socket_timeout
> result = run_impala_shell_cmd(vector, args +
> ['--http_socket_timeout_s=2'])
> shell/util.py:137: in run_impala_shell_cmd
> result.stderr)
> E AssertionError: Cmd ['--quiet', '-B', '--query', 'select 0;',
> '--http_socket_timeout_s=2'] was expected to succeed: Caught exception timed
> out, type=<class 'socket.timeout'> in ExecuteStatement.
> E Caught exception timed out, type=<class 'socket.timeout'> when listing
> query options. Num remaining tries: 3
> E Caught exception timed out, type=<class 'socket.timeout'> in
> ExecuteStatement.
> E Socket error None: timed out
> E Could not execute command: select 0
> E Traceback (most recent call last):
> E File
> "/data/jenkins/workspace/impala-cdw-master-staging-core-asan/repos/Impala/shell/build/python3_venv/bin/impala-shell",
> line 11, in <module>
> E sys.exit(impala_shell_main())
> E File
> "/data/jenkins/workspace/impala-cdw-master-staging-core-asan/repos/Impala/shell/build/python3_venv/lib64/python3.6/site-packages/impala_shell/impala_shell.py",
> line 2306, in impala_shell_main
> E raise FatalShellException()
> E impala_shell.impala_shell.FatalShellException{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
