[
https://issues.apache.org/jira/browse/IMPALA-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058094#comment-18058094
]
ASF subversion and git services commented on IMPALA-14710:
----------------------------------------------------------
Commit 6b4c895f9aa1d3989c343f05270bc6a60815bc45 in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6b4c895f9 ]
IMPALA-14719: Fixed race condition for Calcite property
IMPALA-14710 was filed for a flaky test involving the
calcite.default.charset property. Setting this property
before the jar file is loaded fixes this issue.
This commit also fixes two other issues:
- IMPALA-14384: Class.forName() is only called once now. The compiler
factory is stored in a singleton.
- The Calcite planner is now part of the build and should be in the
target directory. If the user explicitly sets the calcite planner
option and the calcite jar file not found, an error is thrown rather
than falling back.
Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff
Reviewed-on: http://gerrit.cloudera.org:8080/23935
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Flaky test in TestReduceExprShuttle
> -----------------------------------
>
> Key: IMPALA-14710
> URL: https://issues.apache.org/jira/browse/IMPALA-14710
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 5.0.0
> Reporter: Steve Carlin
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> The test seems to be failing because the charset isn't being set properly.
> The charset is set via a static initializer in CalciteCompilerFactory. I
> think this is getting called when
> mvn clean install test
> is run
> but not get getting called when
> mvn clean install -Dtest=TestReduceExprShuttle#testFoldConcatString
> is run.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
