[
https://issues.apache.org/jira/browse/IMPALA-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067229#comment-18067229
]
ASF subversion and git services commented on IMPALA-14706:
----------------------------------------------------------
Commit 4624406c819f866462103948f5525f260b6342f1 in impala's branch
refs/heads/master from Surya Hebbar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4624406c8 ]
IMPALA-14706: Use InMemoryMetricsReporter from the Iceberg library
This change uses the InMemoryMetricsReporter class that is available in
the Iceberg library from release 1.4.0, instead of the user declared
InMemoryMetrcsReporter class.
We are dropping the private static InMemoryMetricsReporter class from
IcebergScanPlanner and will use the Iceberg's builtin class instead.
In addition, the scanMetricsResult() method can be dropped and the
relevant method scanMetrics() can be used directly.
Testing:
- Ran tests related to iceberg locally and examined
Change-Id: I2a5acb54ad6d4b62ff6da26f250e83068a33d316
Reviewed-on: http://gerrit.cloudera.org:8080/23994
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Noemi Pap-Takacs <[email protected]>
> Use MetricsReporter from Iceberg library
> ----------------------------------------
>
> Key: IMPALA-14706
> URL: https://issues.apache.org/jira/browse/IMPALA-14706
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: Noémi Pap-Takács
> Assignee: Surya Hebbar
> Priority: Minor
> Labels: easy, newbie, ramp-up
>
> There is a
> [TODO|https://github.com/apache/impala/blob/3dac0135fba0717dd977043e7ecc6b52bf55189f/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java#L102]
> in IcebergScanPlanner.java:102 that could be resolved now, since we are on a
> newer version of Iceberg:
> MetricsReporter class is available in the Iceberg library from release 1.4.0.
> We should
> drop the private static InMemoryMetricsReporter class from IcebergScanPlanner
> and use the implementation from Iceberg.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
