[
https://issues.apache.org/jira/browse/IMPALA-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072251#comment-18072251
]
ASF subversion and git services commented on IMPALA-14881:
----------------------------------------------------------
Commit 764e225292e07a8de11ed924dbdde4c9221b5ff8 in impala's branch
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=764e22529 ]
IMPALA-14881: Fix instance id in scanner threads
Since IMPALA-6416 the instance id of new threads is inherited
from parent thread instead of setting explicitly. This is not
correct in case of scanner threads (mt_dop=0) when
HdfsScanNode::ThreadTokenAvailableCb is called through
ThreadResourcePool's callback where the thread can come from
an unrelated query.
Note that this issue only affects diagnostics.
Testing:
- tested manually by running parallel scan heavy queries and adding
logging for fragment id in scanner thread - before the fix these
log lines could contain two different instance ids
Change-Id: I2ccfb94353843eaa83cf7371788d0fc151fd3e50
Reviewed-on: http://gerrit.cloudera.org:8080/24174
Reviewed-by: Zoltan Borok-Nagy <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Scanner threads can have incorrect instance id with mt_dop=0
> ------------------------------------------------------------
>
> Key: IMPALA-14881
> URL: https://issues.apache.org/jira/browse/IMPALA-14881
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> IMPALA-6416 added automatic setting of instance id based on parent thread,
> but for scanner threads the parent thread can belong to an unrelated thread
> that releases a thread token.
> The problematic change:
> https://gerrit.cloudera.org/#/c/9053/9/be/src/exec/hdfs-scan-node.cc
> ThreadTokenAvailableCb can be called from outside the instance through as it
> is registered in ThreadResourcePool::AddThreadAvailableCb
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
