[ 
https://issues.apache.org/jira/browse/IMPALA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075211#comment-18075211
 ] 

ASF subversion and git services commented on IMPALA-14901:
----------------------------------------------------------

Commit d8b81c51e9c8b66e2f163cfb233fae9bef28e168 in impala's branch 
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d8b81c51e ]

IMPALA-14895: Added tests for newly supported Calcite queries

Calcite supports parsing and analyzing for some standard SQL queries
which the original planner doesn't. This commit adds end to end tests
for these queries to the test framework.

IMPALA-14901 has been created for adding explain plans for these tests
into the test framework.

Most of the queries are somewhat similar to those found in the
AnalyzeSubqueriesTest file. Those junit tests just validate that an
error is thrown since they are not supported. This commit will test
that the queries now parse and will test the results for correctness.

A small change had to be added to ImpalaAggRel for a query within
calcite_subquery.test that was failing. The line in the file did not
match the comment. All output expressions from the CardinalityCheck input
should be passed through the cardinality check, whereas the code was
only passing through the first one. When the input ref was doing a
cardinality check for the second inputref field, the query was throwing
an exception during compilation time.

One extra test was thrown into this commit, for IMPALA-5098 which does
a SELECT DISTINCT with analytic functions.

Change-Id: I3a69f1bc2fe2fa2c8840e6c3bcf660370c0c9a46
Reviewed-on: http://gerrit.cloudera.org:8080/24196
Reviewed-by: Aman Sinha <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Calcite Planner: add planner tests for newly supported subqueries
> -----------------------------------------------------------------
>
>                 Key: IMPALA-14901
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14901
>             Project: IMPALA
>          Issue Type: Sub-task
>            Reporter: Steve Carlin
>            Priority: Major
>
> In IMPALA-14895, new tests are being added that are only supported in the 
> Calcite planner.  It would be good to have tests for the explain plans of 
> these queries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to