[ 
https://issues.apache.org/jira/browse/IMPALA-14917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076387#comment-18076387
 ] 

ASF subversion and git services commented on IMPALA-14917:
----------------------------------------------------------

Commit bb744927df3b47aa3b38e50b81e8be426dfafba6 in impala's branch 
refs/heads/master from Stamatis Zampetakis
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=bb744927d ]

IMPALA-14917: Centralize Junit version across modules

1. Move version and scope management in dependencyManagement section of
the root pom.xml file to ensure it is used consistently across the
project.
2. Remove now redundant version/scope attributes from fe module.
3. Add explicit dependency to junit in calcite-planner module to avoid
relying on 3rd-party deps to bring it in.

Change-Id: Ic0978a53cc772c609ec2ffdeb3d4f1b50df6b776
Reviewed-on: http://gerrit.cloudera.org:8080/24234
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Centralize Junit version across modules
> ---------------------------------------
>
>                 Key: IMPALA-14917
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14917
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Stamatis Zampetakis
>            Priority: Major
>         Attachments: dep-tree.txt
>
>
> Currently there are three different Junit versions used in the project:
> * junit:junit:jar:4.13.2
> * junit:junit:jar:4.12
> * junit:junit:jar:4.10
> Some are declared explicitly in Impala and other are coming transitively.  To 
> make matters worse in some cases the dependency is also present in the 
> compile/runtime classpath making it part of the engine.
> For more details check dep-tree.txt file
> {noformat}
> mvn dependency:tree -Dincludes=junit:* > dep-tree.txt
> {noformat}
> I bumped into this while I was trying to understand why certain code compiles 
> in some modules and not in others. Obviously different versions == different 
> features == different APIs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to