[
https://issues.apache.org/jira/browse/IMPALA-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076632#comment-18076632
]
ASF subversion and git services commented on IMPALA-14919:
----------------------------------------------------------
Commit 77be2ecfd8edf6533a100f0170126cf0d155bf25 in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=77be2ecfd ]
IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
The test pauses event-processor after executing an ALTER TABLE RENAME
statement, assuming the event will be processed later after that. That's
flaky since the event could actually be processed before the pause
command. Then the first fetch on 'events-skipped' metric happens too
late, e.g., events_skipped_before already counts the first ALTER_TABLE
event.
This patch fixes the issue by fetching the 'events-skipped' metric
before executing the first ALTER TABLE RENAME statement. This ensures
the two ALTER events are processed after that.
Tests:
Ran the test locally 60 times.
Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Reviewed-on: http://gerrit.cloudera.org:8080/24233
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestSelfRenameEvent.test_self_rename_events is flaky
> ----------------------------------------------------
>
> Key: IMPALA-14919
> URL: https://issues.apache.org/jira/browse/IMPALA-14919
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
> Labels: broken-build
>
> Saw this failure in a downstream build
> {noformat}
> metadata.test_event_processing.TestSelfRenameEvent.test_self_rename_events
> (from pytest){noformat}
> h3. Stacktrace
> {noformat}
> /data/jenkins/workspace/impala-cdw-master-core-s3-arm-data-cache/repos/Impala/tests/metadata/test_event_processing.py:806:
> in test_self_rename_events
> assert events_skipped_after == events_skipped_before + 2
> E assert 30 == 31
> E +30
> E -31
> alter_client = <tests.common.impala_connection.ImpylaHS2Connection
> object at 0xffff9850ed30>
> alter_handle = <tests.common.impala_connection.OperationHandle object
> at 0xffff956ffdc0>
> catalogd = <CatalogdProcess PID: 84432
> (/data/jenkins/workspace/impala-cdw-master-core-s3-arm-data-cache/repos/Impala/be/build/la...sts
> -kudu_master_hosts 127.0.0.1 -catalog_service_port=26000
> -state_store_subscriber_port=23020 -webserver_port=25020)>
> events_skipped_after = 30
> events_skipped_before = 29
> self =
> <tests.metadata.test_event_processing.TestSelfRenameEvent object at
> 0xffff956ffcd0>
> start_time = 1776887185.0192785
> unique_database = 'test_self_rename_events_43dbc286'
> version_after_create = 2154{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
