[
https://issues.apache.org/jira/browse/IMPALA-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081999#comment-18081999
]
ASF subversion and git services commented on IMPALA-14370:
----------------------------------------------------------
Commit 21d9843320aa1d45c99c582db8094b8c5c45a379 in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=21d984332 ]
IMPALA-14370: [Patch 2 of 2] - Fix Naming of OpenTelemetry SpanManager
The OpenTelemetry class "SpanManager" is poorly named. Its actual job
is to manage the OpenTelemetry trace for a single query. Renames this
class to "OtelTraceManager".
Testing completed by running relevant ctest and custom cluster tests.
Change-Id: I089dfb0361c82905b5e7c2c4794dcf0cc4e5203d
Generated-by: Github Copilot (GPT-5.3-Codex)
Reviewed-on: http://gerrit.cloudera.org:8080/24084
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> OTel Tracing Skips Queries with Leading Comments
> ------------------------------------------------
>
> Key: IMPALA-14370
> URL: https://issues.apache.org/jira/browse/IMPALA-14370
> Project: IMPALA
> Issue Type: Bug
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Critical
>
> The code in otel.cc that determines whether or not a query should be traced
> does not handle comments if written similar to:
> /*/ comment */select * from tbl
> The code is detecting the first */ as the end of the comment. Impala itself
> does correctly parse this query, so it is not a syntax error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
