[
https://issues.apache.org/jira/browse/IMPALA-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085873#comment-18085873
]
ASF subversion and git services commented on IMPALA-14332:
----------------------------------------------------------
Commit 3ae0a559be45e8d375ca54cc75953182d6d27ff0 in impala's branch
refs/heads/master from Arnab Karmakar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3ae0a559b ]
IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span
When using the hs2-http protocol, the X-Request-Id HTTP header value
is now captured and added as an attribute named "HttpRequestId" on the
root OpenTelemetry span. The iteration count suffix (e.g., "-8" in
"uuid-8") that the Impala shell appends is automatically removed to
provide a clean UUID for tracing.
Implementation details:
- Capture X-Request-Id header in THttpServer and store in ConnectionContext
- Propagate value to SessionState during session creation
- Add HttpRequestId attribute to root span in SpanManager constructor
Testing:
- Added C++ unit tests (otel-test.cc) for request ID processing
- Added Python integration test using ImpalaHS2Client over hs2-http
- Test verifies HttpRequestId attribute format and cross-checks with logs
Change-Id: I9e14f5b503ff7379463332bae34c266afc395524
Reviewed-on: http://gerrit.cloudera.org:8080/24008
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Michael Smith <[email protected]>
> Include X-Request-Id Header Value in Root OpenTelemetry Span
> ------------------------------------------------------------
>
> Key: IMPALA-14332
> URL: https://issues.apache.org/jira/browse/IMPALA-14332
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 5.0.0
> Reporter: Jason Fehr
> Assignee: Arnab Karmakar
> Priority: Critical
> Fix For: Impala 5.0.0
>
>
> When using the hs2-http protocol, if the "X-Request-Id" HTTP header is
> specified, add its value as an attribute named "HttpRequestId" on the root
> OpenTelemetry span.
> Note: Impala shell includes the iteration count along with the request id
> guid. For example: "x-request-id=18bb03c8-7de6-11f0-9112-8b736586fd91-8".
> The iteration count will have to be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
