[
https://issues.apache.org/jira/browse/IMPALA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086688#comment-18086688
]
ASF subversion and git services commented on IMPALA-14838:
----------------------------------------------------------
Commit b1ef0fa9f736ed2f32037322c006c7169e9948b4 in impala's branch
refs/heads/master from Aleksandr Efimov
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b1ef0fa9f ]
IMPALA-14838: Count open deferred RPC intervals
TotalHasDeferredRPCsTime was only updated when a sender queue
drained its deferred RPC queue. If the queue was still non-empty
when the profile was sampled, the counter stayed at zero even
though RPCs had been deferred.
Use RuntimeProfile::ConcurrentTimerCounter for
TotalHasDeferredRPCsTime and start/stop it when a sender queue
deferred RPC interval opens or closes. This keeps completed time
and an open interval visible in the live profile while avoiding
double-counting overlapping intervals across sender queues.
Add a data-stream regression test that keeps the receiver reader
stopped, waits until an RPC is deferred, and verifies that the live
profile reports deferred RPC time before cancellation drains the
queue.
Testing:
- git diff --check
- data-stream-test
Assisted-by: OpenAI Codex
Change-Id: I5efe8016b268e3707a2b7b99c488de69ccdad8e6
Reviewed-on: http://gerrit.cloudera.org:8080/24375
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TotalHasDeferredRPCsTime is not set if deferred_rpcs_ is never empty
> ---------------------------------------------------------------------
>
> Key: IMPALA-14838
> URL: https://issues.apache.org/jira/browse/IMPALA-14838
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Aleksandr Efimov
> Priority: Major
> Labels: ramp-up
>
> Saw these conflicting counters in a cancelled profile:
> - TotalHasDeferredRPCsTime: 0.000ns
> - TotalRPCsDeferred: 1.36K (1364)
> The issue is that TotalHasDeferredRPCsTime is only increased when the queue
> gets empty so will be 0 if the query is cancelled while the queue was never
> depleted:
> https://github.com/apache/impala/blob/ef2d50e68987ccbf713122b8f301709a874c5121/be/src/runtime/krpc-data-stream-recvr.cc#L339
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
