[ 
https://issues.apache.org/jira/browse/IMPALA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087545#comment-18087545
 ] 

ASF subversion and git services commented on IMPALA-12696:
----------------------------------------------------------

Commit cf03d93762e482abcbe5bef5dcd5cb7ea570d175 in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cf03d9376 ]

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since 2022) TCLIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the
generated python artifacts for impyla which is also used with Hive.
Using the new possibilites in the protocol could be done in follow up
patches.

Generated-by: Cloude Sonnet 4.6

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Reviewed-on: http://gerrit.cloudera.org:8080/24376
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>


> Update to a newer version of TCLIService.thrift
> -----------------------------------------------
>
>                 Key: IMPALA-12696
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12696
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Clients
>    Affects Versions: Impala 4.4.0
>            Reporter: Joe McDonnell
>            Priority: Major
>
> Impala uses an old version of TCLIService.thrift (V6) and Hive has made 
> several additions to the protocol. We should move to a more recent version of 
> TCLIService.thrift from Hive to reduce the divergence.
> Prototype here: [https://gerrit.cloudera.org/#/c/20495/]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to