[ 
https://issues.apache.org/jira/browse/IMPALA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097015#comment-18097015
 ] 

ASF subversion and git services commented on IMPALA-15158:
----------------------------------------------------------

Commit cd653ccaaca65815cf5a43ec38e4230113ab306d in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cd653ccaa ]

IMPALA-15158: Replace ColumnType.is_binary_ with an enum

This is preparation for adding new types that piggy-back
on STRING (GEOMETRY/GEOGRAPHY). The new types will be
available only in Parquet, so adding the actual types
later should not need to modify unrelated file formats.

Change-Id: I667138dac8afdd117dea8ed90a85927352f73269
Reviewed-on: http://gerrit.cloudera.org:8080/24567
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>


> GEOMETRY preparation: replace is_binary_ with enum in BE
> --------------------------------------------------------
>
>                 Key: IMPALA-15158
>                 URL: https://issues.apache.org/jira/browse/IMPALA-15158
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend
>            Reporter: Csaba Ringhofer
>            Assignee: Csaba Ringhofer
>            Priority: Major
>
> ColumnType::is_binary_ is used to avoid creating a new type for BINARY in the 
> backend - it piggy backs most of the time on STRING, and only a few places 
> need to check whether it is BINARY or STRING. The same mechanism could be 
> used for GEOMETRY (and GEOGRAPHY), which will be clearer if the bool is 
> replaced with an enum about the logical type the array represents.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to