[
https://issues.apache.org/jira/browse/IMPALA-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098517#comment-18098517
]
ASF subversion and git services commented on IMPALA-15207:
----------------------------------------------------------
Commit 7b1e0fe07b58961a095d39bee7b6b36ca73716e9 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7b1e0fe07 ]
IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
MetaProviderDecoratorTest.testMetaProviderMethodCount tests
that MetaProvider has a specific number of public methods.
Jacoco code coverage adds its own '$jacocoInit' method, and
this throws the count off. This filters out Jacoco's method
to avoid the discrepancy.
Testing:
- Ran MetaProviderDecoratorTest.testMetaProviderMethodCount
with code coverage
Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Reviewed-on: http://gerrit.cloudera.org:8080/24623
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
> MetaProviderDecoratorTest.testMetaProviderMethodCount fails on coverage builds
> ------------------------------------------------------------------------------
>
> Key: IMPALA-15207
> URL: https://issues.apache.org/jira/browse/IMPALA-15207
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Labels: broken-build
>
> On exhaustive code coverage builds,
> MetaProviderDecoratorTest.testMetaProviderMethodCount consistently fails with:
> {noformat}
> Number of public methods in MetaProvider interface has changed. Update
> EXPECTED_METHOD_COUNT and add tests for new methods.
> Expected: <24>
> but: was <25>{noformat}
> This is a consistent failure. Maybe coverage adds an additional method? If
> so, we could filter it out to avoid having a different count.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
