[
https://issues.apache.org/jira/browse/IMPALA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099571#comment-18099571
]
ASF subversion and git services commented on IMPALA-14983:
----------------------------------------------------------
Commit af921e26f030043a2340eb565348b204d9b74297 in impala's branch
refs/heads/master from Anubhav Jindal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=af921e26f ]
IMPALA-14983: Add typed operator config keys
Add typed configuration fields under ImpalaCluster spec.config for
impalad, catalogd, statestored, and HMS daemon flags plus impalad query
defaults.
Map the typed fields into Helm values in the operator reconciler while
keeping spec.set as a backward-compatible advanced override path.
Add focused operator unit tests covering typed set-arg rendering,
escaping behavior, and LDAP disable/reconciliation edge cases.
Update CRD schema, sample ImpalaCluster, and Kubernetes deployment guide
with typed-key examples and escaping guidance.
Testing:
- python3 -m py_compile operator/impala-operator/main.py
- python3 operator/impala-operator/tests/test_main.py
- ruby YAML parsing for CRD and sample ImpalaCluster manifests
- kubectl config current-context (k3d-impala-live)
- kubectl apply -f operator/impala-operator/manifests/crd-impalacluster.yaml
- kubectl apply -f operator/impala-operator/manifests/rbac.yaml
- kubectl create namespace impala-14983-live
- /tmp/impala-op-venv/bin/python reconcile driver invoking _ensure_namespace,
_ensure_ldap, and _ensure_impala with
spec.config.impalad.flags.num_reactor_threads=0 and
spec.config.impalad.queryDefaults={default_file_format=parquet,mt_dop=4}
- kubectl rollout status deployment/impala-14983-live-impala-
{statestored,catalogd,impalad,hms} -n impala-14983-live
- kubectl get deployment impala-14983-live-impala-impalad -n
impala-14983-live -o jsonpath='{.spec.template.spec.containers[0].args}'
(contains -num_reactor_threads=0 and
-default_query_options=default_file_format=parquet,mt_dop=4)
- helm -n impala-14983-live status impala-14983-live (STATUS: deployed)
- kubectl get pods -n impala-14983-live (all core pods Running/Ready)
Change-Id: Ie24380d4700cf8377f291de2406cb6ed12f6d6f4
Assisted-by: GPT-5.3 (Cursor)
Reviewed-on: http://gerrit.cloudera.org:8080/24365
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>
> Add typed operator config keys for daemon flags and query defaults
> ------------------------------------------------------------------
>
> Key: IMPALA-14983
> URL: https://issues.apache.org/jira/browse/IMPALA-14983
> Project: IMPALA
> Issue Type: Task
> Reporter: Anubhav Jindal
> Assignee: Anubhav Jindal
> Priority: Major
>
> * *Problem:* Config updates via raw {{{}spec.set{}}}/indexed {{extraArgs}}
> are error-prone and hard to operate.
> * *Proposed Change:* Add typed {{spec.config}} fields (daemon flags +
> impalad query defaults) and map them to Helm values in reconciler, while
> preserving backward compatibility with {{{}spec.set{}}}.
> * *Testing:* Patch CR with typed keys; verify operator translates values,
> performs reconcile, and resulting pod args/options reflect updates.
> * *Compatibility/Risk:* Backward compatible; {{spec.set}} remains supported
> as escape hatch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
