[
https://issues.apache.org/jira/browse/IMPALA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Gaal updated IMPALA-15230:
---------------------------------
Description:
The context builder script, which runs during Impala container image builds,
contains a meticulous check to verify that all the jars referenced on the
frontend's CLASSPATH are actually present in the build context, so that they
can all be written to the image.
This verification check contains explicit exclusions for test jars (built for
the Calcite planner and the traditional Impala frontend). Unfortunately this
test in
[https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L204]
and in
[https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L207]
is too aggressive: they fail if the "tests" substring is present anywhere in
the jar's full pathname, not only when it is part of the jar's name itself. The
check should be constrained to the look at only the jar's own name.
Found during downstream testing when $IMPALA_HOME's containing directory was
called "dockerised_test", containing the "tests" substring, leading to an
abrupt build failure.
was:
The context builder script, which runs during Impala container image builds,
contains a meticulous check to verify that all the jars referenced on the
frontend's CLASSPATH are actually present in the build context, so that they
can all be written to the image.
This verification check contains explicit exclusions for test jars (built for
the Calcite planner and the traditional Impala frontend). Unfortunately this
test in
[https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L204]
and in
[https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L207]
is too aggressive: they fail if the "test" substring is present anywhere in
the jar's full pathname, not only when it is part of the jar's name itself. The
check should be constrained to the look at only the jar's own name.
Found during downstream testing when $IMPALA_HOME's containing directory was
called "dockerised_test", containing the "test" substring, leading to an abrupt
build failure.
> Docker image builds fail if IMPALA_HOME contains the word "tests"
> -----------------------------------------------------------------
>
> Key: IMPALA-15230
> URL: https://issues.apache.org/jira/browse/IMPALA-15230
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Laszlo Gaal
> Assignee: Laszlo Gaal
> Priority: Major
>
> The context builder script, which runs during Impala container image builds,
> contains a meticulous check to verify that all the jars referenced on the
> frontend's CLASSPATH are actually present in the build context, so that they
> can all be written to the image.
> This verification check contains explicit exclusions for test jars (built for
> the Calcite planner and the traditional Impala frontend). Unfortunately this
> test in
> [https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L204]
> and in
> [https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L207]
> is too aggressive: they fail if the "tests" substring is present anywhere in
> the jar's full pathname, not only when it is part of the jar's name itself.
> The check should be constrained to the look at only the jar's own name.
> Found during downstream testing when $IMPALA_HOME's containing directory was
> called "dockerised_test", containing the "tests" substring, leading to an
> abrupt build failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
