[
https://issues.apache.org/jira/browse/IMPALA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101477#comment-18101477
]
ASF subversion and git services commented on IMPALA-14852:
----------------------------------------------------------
Commit 1b4dc6f2757580a1b22c87194999449fe2cad053 in impala's branch
refs/heads/master from Balazs Hevele
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1b4dc6f27 ]
IMPALA-15235: Fix ARM crash in KrpcDataStreamSender::SerializeBatch
The crash was caused by the following mismatch:
-OutboundRowBatch::AppendRowWithDedup returns a Status struct (sret)
-The LLVM function created in
OutboundRowBatch::CodegenAppendRowWithDedup created a function
prototype with the first "status" argument being a normal argument (no
sret)
-When replacing the call sites between these two, the registers were
mismatched (on ARM, where the registers are shifted on sret), causing
garbage values, eventually leading to a load on an unexpected value
The crash was introduced with IMPALA-14852.
The fix is to mark first "status" argument of the function prototype
explicitly as sret in OutboundRowBatch::CodegenAppendRowWithDedup.
Change-Id: I00e5dd328d7b2c7e44b1d2af3eebda4d14ec99c2
Reviewed-on: http://gerrit.cloudera.org:8080/24653
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Codegen tuple copy for Broadcast Exchange
> -----------------------------------------
>
> Key: IMPALA-14852
> URL: https://issues.apache.org/jira/browse/IMPALA-14852
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Balazs Hevele
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> Codegen tuple copy for OutBoundRowBatch, and use it in
> KrpcDataStreamRecvr/Sender.
> If possible, use common deepcopy functions with other systems (e.g.
> Tuple::TryDeepCopy*).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
