[
https://issues.apache.org/jira/browse/IMPALA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106439#comment-18106439
]
ASF subversion and git services commented on IMPALA-15230:
----------------------------------------------------------
Commit c47f8cce53e3262bde67f881f9591be93b831fe2 in impala's branch
refs/heads/master from Laszlo Gaal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c47f8cce5 ]
IMPALA-15230: Restrict the check for "tests" to the jar name proper
...during Docker image builds.
The context builder script that runs during Impala Docker image builds
screens out test jars by checking the file name for the "tests" substring
for certain jars. This check is too aggressive: it triggers if any
part of the full pathname, even an enclosing directory name
contains "tests", breaking the container build.
This patch constrains the check to the jar name itself by splitting
off the basename of the jar before checking. It also converts the
assertion into an Exception with a message so that the check is not
skipped if the script happens to run in Python's optimized mode.
Change-Id: Idb783e3c7dfc064d7a6ed6804e429393a0de3cbf
Reviewed-on: http://gerrit.cloudera.org:8080/24645
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
> Docker image builds fail if IMPALA_HOME contains the word "tests"
> -----------------------------------------------------------------
>
> Key: IMPALA-15230
> URL: https://issues.apache.org/jira/browse/IMPALA-15230
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Laszlo Gaal
> Assignee: Laszlo Gaal
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> The context builder script, which runs during Impala container image builds,
> contains a meticulous check to verify that all the jars referenced on the
> frontend's CLASSPATH are actually present in the build context, so that they
> can all be written to the image.
> This verification check contains explicit exclusions for test jars (built for
> the Calcite planner and the traditional Impala frontend). Unfortunately this
> test in
> [https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L204]
> and in
> [https://github.com/apache/impala/blob/master/docker/setup_build_context.py#L207]
> is too aggressive: they fail if the "tests" substring is present anywhere in
> the jar's full pathname, not only when it is part of the jar's name itself.
> The check should be constrained to the look at only the jar's own name.
> Found during downstream testing when $IMPALA_HOME's containing directory was
> called "dockerised_test", containing the "tests" substring, leading to an
> abrupt build failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
