[
https://issues.apache.org/jira/browse/IMPALA-15308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108877#comment-18108877
]
ASF subversion and git services commented on IMPALA-15308:
----------------------------------------------------------
Commit f71f9284bedebad9557cd0b9608a1eeb5c13405e in impala's branch
refs/heads/master from Aleksandr Efimov
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f71f9284b ]
IMPALA-15308: Share Iceberg DML finalization
Extract the Iceberg operation, transaction commit, and cleanup
sequence from CatalogOpExecutor into a package-local helper.
CatalogD keeps its HMS hook and timeline behavior.
This creates a shared finalization seam for later REST catalog DML
without changing existing CatalogD semantics.
Testing:
- IcebergDmlFinalizerTest
- Focused Java and CatalogD build
Change-Id: I0dc13bba0cc4e06d423dca7ec849b3a23f447625
Assisted-by: gpt-5.6-sol (OpenAI Codex)
Reviewed-on: http://gerrit.cloudera.org:8080/24734
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Zoltan Borok-Nagy <[email protected]>
> Extract Iceberg DML finalization into a shared helper
> -----------------------------------------------------
>
> Key: IMPALA-15308
> URL: https://issues.apache.org/jira/browse/IMPALA-15308
> Project: IMPALA
> Issue Type: Sub-task
> Components: Catalog, Frontend
> Reporter: Aleksandr Efimov
> Assignee: Aleksandr Efimov
> Priority: Major
> Labels: impala-iceberg
> Fix For: Impala 5.0.0
>
>
> CatalogOpExecutor runs the Iceberg DML sequence inline: execute the operation
> against the transaction, commit it, and delete the uncommitted data/delete
> files when the commit fails. DML for tables served by a REST catalog needs
> the same sequence but does not run in CatalogD, so it cannot reuse that code.
> Move the sequence into IcebergDmlFinalizer. CatalogD passes a hook that runs
> between the operation and the commit, where it sets its HMS event properties,
> so its behavior does not change.
> Prerequisite for INSERT INTO on REST catalog tables.
> Review: https://gerrit.cloudera.org/#/c/24734/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
