Aleksandr Efimov created IMPALA-15319:
-----------------------------------------
Summary: Calcite planner: share one seam-plan helper between the
module's tests
Key: IMPALA-15319
URL: https://issues.apache.org/jira/browse/IMPALA-15319
Project: IMPALA
Issue Type: Sub-task
Components: Frontend
Reporter: Aleksandr Efimov
IMPALA-15282 adds CalciteSeamTestBase, which gets a query to the pre-conversion
seam for the Substrait tests: parseAndAnalyze with CalciteCompilerFactory,
CalciteRelNodeConverter.convert, CalciteOptimizer.createPreImpalaConvertPlan,
and getFieldNames for the output labels.
CalciteOptimizerTest already had its own copy of that sequence, so the module
now holds two of them. Folding the older one in needs a little more from the
base class than the Substrait tests use: that test also calls optimize() on the
full optimizer, so it needs the optimizer and the logical plan separately
rather than only the seam plan.
Kept out of the Substrait patches on purpose, since it changes a test that has
nothing to do with Substrait.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
