[ 
https://issues.apache.org/jira/browse/ARTEMIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563037#comment-14563037
 ] 

ASF GitHub Bot commented on ARTEMIS-125:
----------------------------------------

GitHub user mnovak opened a pull request:

    https://github.com/apache/activemq-artemis/pull/5

    ARTEMIS-125 Shared backup server with disabled scale down policy does…

    … not activate.
    
    If standalone backup server with shared has defined scale-down policy
    but it's disabled then backup does not activate. Problem is that
    server is checking only whether scale down is defined but if it's
    enabled. This causes that server.stop() is called and backup does
    not activate.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mnovak/activemq-artemis 
check-scale-down-policy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 73c7fc86fc6901b1dea0b0a2a096ca7c38508fd6
Author: mnovak <mno...@redhat.com>
Date:   2015-05-28T14:53:31Z

    ARTEMIS-125 Shared backup server with disabled scale down policy does not 
activate itself.
    
    If standalone backup server with shared has defined scale-down policy
    but it's disabled then backup does not activate. Problem is that
    server is checking only whether scale down is defined but if it's
    enabled. This causes that server.stop() is called and backup does
    not activate.

----


> Standalone backup server with shared store does not start if scaledown policy 
> is defined but not enabled
> --------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-125
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-125
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.0.0
>            Reporter: Miroslav Novak
>             Fix For: 1.1.0
>
>
> If standalone shared backup is configured with disabled scale-down policy 
> then after failover backup stop itself.
> Debugging showed that server.stop() is called in 
> org.apache.activemq.artemis.core.server.impl.SharedStoreBackupActivation in 
> line 102:
> {code}
> public void run()
>   ...
>          boolean scalingDown = SharedStoreSlavePolicy.getScaleDownPolicy() != 
> null;
> ...
>          if (scalingDown)
>        ...
>                      activeMQServer.stop();
>        ...
> {code}
> There is only check whether scale down policy was defined but not whether 
> it's enabled/disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to