[ https://issues.apache.org/jira/browse/ARTEMIS-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137546#comment-15137546 ]
Justin Bertram edited comment on ARTEMIS-391 at 2/8/16 9:36 PM: ---------------------------------------------------------------- Adding the logging here is easy. However, I'm not sure if anything extra needs to be done to ensure the connection is closed. When I modified the tests in {{org.apache.activemq.artemis.tests.integration.server.ConnectionLimitTest}} to check {{org.apache.activemq.artemis.core.server.ActiveMQServer#getConnectionCount}} everything looked as expected (i.e. only 1 connection was active at the end of the test). Do you see something I need to add to make sure the connection is closed? was (Author: jbertram): Adding the logging here is easy. However, I'm not sure if anything extra needs to be done to ensure the connection is closed. When I modified the tests in [[org.apache.activemq.artemis.tests.integration.server.ConnectionLimitTest]] to check [[org.apache.activemq.artemis.core.server.ActiveMQServer#getConnectionCount]] everything looked as expected (i.e. only 1 connection was active at the end of the test). Do you see something I need to add to make sure the connection is closed? > Connection Limit doesn't log when over the limit > ------------------------------------------------ > > Key: ARTEMIS-391 > URL: https://issues.apache.org/jira/browse/ARTEMIS-391 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: clebert suconic > Assignee: Justin Bertram > Fix For: 1.3.0 > > > The current security limit doesn't log anything when going beyond the limit: > there is a Log.DEBUG, and an empty exception that is not shown anywhere. > else { > if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) { > ActiveMQServerLogger.LOGGER.debug(new > StringBuilder().append("Connection limit of > ").append(connectionsAllowed).append(" reached. Refusing connection from > ").append(ctx.channel().remoteAddress())); > } > throw new Exception(); > } > The conneciton should be closed, and proper log should be printed. I think > this is a situation for log.warn as the admins will need to be aware of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)