[ https://issues.apache.org/jira/browse/AMQ-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250532#comment-15250532 ]
ASF subversion and git services commented on AMQ-5621: ------------------------------------------------------ Commit 10478c313e81f0209ed5cb89e9c7529870e6a300 in activemq's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=10478c3 ] https://issues.apache.org/jira/browse/AMQ-5621 Update tests to not use hardcoded port for the transport connector and remove the unneeded sleep calls with proper test setup > Unit tests cleanup > ------------------ > > Key: AMQ-5621 > URL: https://issues.apache.org/jira/browse/AMQ-5621 > Project: ActiveMQ > Issue Type: Improvement > Reporter: Timothy Bish > Assignee: Timothy Bish > Priority: Minor > > Many of the existing test cases take longer than they should and fail > randomly due to BrokerService instances that are still running that have open > JMX connectors etc. We should take some time to review tests and clean up > were we can. > Removing hard sleeps and using admin view to check statistics can > dramatically shorten a test. Also the tests can be configured not to create > JMX connectors as none of them need that in the normal case. > Other tasks that could be done is to update tests to JUnit 4 based tests with > test timeouts to help prevent CI hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)