[
https://issues.apache.org/jira/browse/ARTEMIS-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262953#comment-15262953
]
Justin Bertram commented on ARTEMIS-382:
----------------------------------------
The synchronization is coordinating work between the isWritable and fireReady
methods. These are the only places where readyListeners is being used. It
looks fine to me. I'll go ahead and close this.
> Synchronization performed on java.util.concurrent.ConcurrentLinkedDeque
> object in class NettyConnection
> -------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-382
> URL: https://issues.apache.org/jira/browse/ARTEMIS-382
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Martin Styk
> Assignee: Justin Bertram
> Priority: Minor
>
> Static code analysis tool discovered defect in class NettyConnection.
> There is performed synchronisation on
> java.util.concurrent.ConcurrentLinkedDeque object in method public void
> fireReady(final boolean ready) .
> Affected part of code :
> private final ConcurrentLinkedDeque<ReadyListener> readyListeners = new
> ConcurrentLinkedDeque<>();
> public void fireReady(final boolean ready) {
> synchronized (readyListeners) {
> this.ready = ready;
> .....
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
