[
https://issues.apache.org/jira/browse/ARTEMIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395465#comment-15395465
]
ASF GitHub Bot commented on ARTEMIS-642:
----------------------------------------
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/672#discussion_r72421190
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/DisconnectConsumerWithKillMessage.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.core.impl.wireformat;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl;
+
+public class DisconnectConsumerWithKillMessage extends PacketImpl {
+
+ private SimpleString nodeID;
+
+ public DisconnectConsumerWithKillMessage(final SimpleString nodeID) {
+ super(DISCONNECT_CONSUMER_KILL);
+ this.nodeID = nodeID;
+ }
+
+ public DisconnectConsumerWithKillMessage() {
--- End diff --
Is this constructor needed? If not, then the field can be final.
> Disable slow client reconnecting with KILL slow client policy
> -------------------------------------------------------------
>
> Key: ARTEMIS-642
> URL: https://issues.apache.org/jira/browse/ARTEMIS-642
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 1.3.0
> Reporter: Chen Maoqian
> Priority: Minor
>
> It is possible to detect and handle(KILL, NOTIFY) slow consumers. In case
> policy KILL is used and connection factory used to create connection of slow
> consumer has attribute reconnect-attempts set to "-1", slow consumer
> reconnects to server. This consumer is then reconnects, is detected as slow
> and disconnected.
> Attribute reconnect-attempts="-1" should be ignored, and slow client should
> not be trying to reconnect once it is disconnected by KILL slow consumer
> policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
