[ https://issues.apache.org/jira/browse/AMQ-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705821#comment-15705821 ]
ASF GitHub Bot commented on AMQ-5859: ------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/122 > Reconnection attempt logic seems wrong in JmsConnector#doInitializeConnection > ----------------------------------------------------------------------------- > > Key: AMQ-5859 > URL: https://issues.apache.org/jira/browse/AMQ-5859 > Project: ActiveMQ > Issue Type: Bug > Components: Broker > Affects Versions: 5.10.2, 5.11.1 > Reporter: Benoit Wiart > Priority: Critical > Fix For: 5.12.0 > > Attachments: > 0001-AMQ-5859-Reconnection-attempt-logic-seems-wrong-in-J.patch > > > the reconnection attempts logic based on the reconnection policy seems wrong. > In JmsConnector#doInitializeConnection the loop trying to reconnect to the > foreign broker only execute once due to the erroneous test in the while > {code} > while (maxRetries < ++attempt && !connectionSerivce.isTerminating()); > {code} > should be > {code} > while (maxRetries > ++attempt && !connectionSerivce.isTerminating()); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)