[ 
https://issues.apache.org/jira/browse/ARTEMIS-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945192#comment-15945192
 ] 

ASF GitHub Bot commented on ARTEMIS-1074:
-----------------------------------------

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1139#discussion_r108424112
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
 ---
    @@ -20,6 +20,8 @@
     import javax.crypto.SecretKeyFactory;
     import javax.crypto.spec.PBEKeySpec;
     import javax.crypto.spec.SecretKeySpec;
    +import javax.naming.ConfigurationException;
    --- End diff --
    
    I'd recommend java.lang.IllegalArgumentException.


> Acceptors and Connectors that enable SSL don’t start up while using a 
> password codec
> ------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1074
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1074
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.3, 2.0.0
>            Reporter: Armand Roelens
>            Priority: Critical
>              Labels: security
>         Attachments: exception.png
>
>
> When configuring acceptors/connectors in the artemis.xml to use SSL and a 
> password codec for password encryption (masking-password is enabled to true), 
> the following exception (attached to the ticket) occurs preventing the 
> acceptors/connectors from starting up.
> The getPasswordProperty() method in the ConfigurationHelper expects both the 
> masking password property and the password codec property as input arguments, 
> however the masking password property is being passed in place of the 
> password codec property (thus being passed in twice) which will cause an 
> exception to occur.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to