[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009486#comment-16009486 ]
ASF GitHub Bot commented on ARTEMIS-1163: ----------------------------------------- Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 @klausboeing, I'm not exactly sure what you're asking. Once the PR is merged I'll close the JIRA. At this point you need to squash the two commits together into a single commit. > Refactory connection factory client creation > -------------------------------------------- > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.2.0 > Reporter: Klaus Boeing > Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)